search

cdev-tux / q3lite

Q3lite, an OpenGL ES port of Quake III Arena for embedded Linux systems.
GNU General Public License v3.0
93 stars 16 forks source link

Add auto-detection for Vero4k and 1 bug fix #8

Closed hissingshark closed 5 years ago

hissingshark commented 6 years ago

Add auto-detection for Vero4k...

FIX: A macro bin_path was being borrowed from Makefile by Makefile.q3lite but was undefined at the time of its use. The result is incorrectly blank, but goes unnoticed on an RPi as it's likely the desired behavior.

cdev-tux commented 6 years ago

Hello,

Thanks for submitting this. I’ll be able to look deeper into this PR in a week or so, but have a few initial comments. In order to implement this it would require updating the modified Mali/SDL2 libraries, as a SDL2 bug fix for the Raspberry Pi has been added since 2.0.8 was released. I would also need to add the framework to allow running on multiple platforms, as it's currently set up for the Raspberry Pi only. It’s doable, but will require additional time to update the code and documentation.

Concerning variable declarations in the makefile; there are other variables that didn’t pass from the makefile to makefile.q3lite so it might make sense to look at relocating the references to additional makefiles in the main makefile itself. I’m not a makefile expert by any means so I’ll need to dig into this and do some testing.

Thanks

hissingshark commented 6 years ago

OK, clearly needs work then. No hurry - we're all doing this as a hobby!

While I'm here, I've just contributed RetroPie support for my platform. How do you feel about me adding Q3lite as it's running so well? I'd be incorporating elements of your installer to download the .paks, acknowledge the EULA etc. Also, do I understand right it it's all legal to distribute/download and assumes you have your own paid for CD key?

cdev-tux commented 5 years ago

I’m going to close this pull request since the framework to implement it in the source code hasn’t been added yet, and it doesn’t contain all of the necessary code for others to use it on the Vero4k platform. If I can find the time to add the Mali GLES code to Q3lite then we can revisit this. Thanks for your help!