search

cdevents / sdk-java

Java SDK for CDEvents
Apache License 2.0
5 stars 6 forks source link

Core CDEvents to render as CloudEvent and schema validation #41

Closed rjalander closed 1 year ago

rjalander commented 1 year ago

This PR is a continuation of https://github.com/cdevents/sdk-java/pull/35, to implement other Core events

rjalander commented 1 year ago

Thank you. Yes, we need to remove the old implementation CDEventTypes.java and it's UT related files.

afrittoli commented 1 year ago

Thank you. Yes, we need to remove the old implementation CDEventTypes.java and it's UT related files.

It would be nice to have it in this PR, I think, or do you plan on removing the old implementation all the end at once? Since this is a new package it may be ok, as long is all happen this week.

rjalander commented 1 year ago

Yes, we are still creating PRs for Source Code, Continues Integration and Deployment events to implement with this approach and planning to complete in couple of days. I think I will create another PR once at the end.

afrittoli commented 1 year ago

Thank you! It just came to mind that perhaps we should use the spec version v0.1.2 instead of v0.1.0 as starting point here since there were a couple of issues in the v0.1.0 version, the reason why we made the patch releases.

rjalander commented 1 year ago

Ok, so we don't need to maintain a v0.1.0 version for Java-SDK and I can update this and other event PRs to use v0.1.2 from now?

afrittoli commented 1 year ago

Ok, so we don't need to maintain a v0.1.0 version for Java-SDK and I can update this and other event PRs to use v0.1.2 from now?

Indeed, please use v0.1.2 - there are a few bug fixes that's good to have in.

rjalander commented 1 year ago

Thank you @afrittoli, updated this PR to use 0.1.2 specification.

rjalander commented 1 year ago

@afrittoli are we good to merge this PR now.

cdevents-bot commented 1 year ago

🎉 This issue has been resolved in v0.1.2 (Release Notes)