chore: add pre-commit job and change test job in CI workflow

cdevents / sdk-python

Python SDK for CDEvents

Apache License 2.0

4 stars 8 forks source link

chore: add pre-commit job and change test job in CI workflow #7

Closed randomnoise closed 2 years ago

randomnoise commented 2 years ago

Fixes #2.

Changes

added pre-commit job in CI worklow
change test jobs to working state in CI workflow

randomnoise commented 2 years ago

Pre-commit job failed and this is expected. When I run make check (which is pre-commit run --all-files), I get the same errors on a local dev environment.

erkist commented 2 years ago

Awesome, thanks for the PR! I will see if I can fix the underlying errors so that the check runs successfully in the pipeline as well.

erkist commented 2 years ago

@randomnoise If you rebase this PR on latest main I hope it will fix the pipeline issues.

randomnoise commented 2 years ago

Thanks for the update @erkist and the work on pre-commit fixes with #8.

I rebased my branch on latest main. I cannot start a re-test on this repo; but I tested on my fork, it seems your latest commit fixed the pre-commit errors for pre-commit CI job 👍

Result: https://github.com/randomnoise/sdk-python/actions/runs/3185336130

erkist commented 2 years ago

The new workflow works great! Thank you very much for the contribution @randomnoise! It will really help us as we are going to do quite a few updates to the SDK for the 0.1 release of CDEvents and it is great to have automated verification in place. 🥇