search

cdevents / spec

A common specification for Continuous Delivery events
Apache License 2.0
133 stars 23 forks source link

Adds JSON linting #223

Closed xibz closed 6 months ago

xibz commented 6 months ago

eslint --fix

This commit addresses some of the inconsistencies in our
JSON files
xibz commented 6 months ago

Cherry pick of #205

afrittoli commented 6 months ago

Must merge after #220 (to enable CI) and #222 (to remove the snake case)

afrittoli commented 6 months ago

Thanks for fixing this! I just noticed that the superlinter logs at the end say:

2024-05-15 01:14:53 [INFO]   ERROR! Failed to call GitHub Status API!
2024-05-15 01:14:53 [INFO]   ERROR:[curl: (22) The requested URL returned error: 403]
2024-05-15 01:14:53 [INFO]   ERROR! Failed to call GitHub Status API!
2024-05-15 01:14:53 [INFO]   ERROR:[curl: (22) The requested URL returned error: 403]
2024-05-15 01:14:53 [NOTICE]   All file(s) linted successfully with no errors detected

I imagine that superlinter is trying to report back something, but failing because of missing authorization. This is most certainly not new in this PR, just something we may want to fix later on.