cdew / delphipi

Automatically exported from code.google.com/p/delphipi
0 stars 0 forks source link

Adjustments for scripting #19

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi Ibrahim,

First, you did a great job with this installer, it is exactly what I am
looking for.
I found that scripting was not finished, so I made some adjustments.
If you are interested I can sent you an update of the source.
I also added the possiblity to update the "Library Search Paths" from script.

Greetings

Ronald Siekman

Original issue reported on code.google.com by ronaldsi...@gmail.com on 2 Jan 2009 at 8:58

GoogleCodeExporter commented 9 years ago
Hello Ronald,

I always accept patches. Thanks for your interest and effort. You can accept 
patch
file to your comment and I can apply adjust source code depending on it.

Thanks again.

Original comment by ibrahim....@gmail.com on 2 Jan 2009 at 9:11

GoogleCodeExporter commented 9 years ago
I forgot to ask if you have made your changes to the source that is on the 
download
section or the latest trunk because latest trunk contains a console compiler 
and some
improvements on the scripting feature. So if you have applied your changes to 
the
source in the zip file then some of your changes may be not applicable.

Original comment by ibrahim....@gmail.com on 2 Jan 2009 at 9:28

GoogleCodeExporter commented 9 years ago
Yes I made some changes on patch 0.42, and yes they are needed to get the 
script work
properly. Some of your changes are the same as mine (or a little different), 
but i did more.
Maybe you can use it. I added my updates

Original comment by ronaldsi...@gmail.com on 2 Jan 2009 at 10:30

Attachments:

GoogleCodeExporter commented 9 years ago
Hello Ronald,

Thanks for updates. I will merge them accordingly as soon as possible.

Original comment by ibrahim....@gmail.com on 9 Jan 2009 at 6:12

GoogleCodeExporter commented 9 years ago
Great thx

Original comment by ronaldsi...@gmail.com on 9 Jan 2009 at 10:06

GoogleCodeExporter commented 9 years ago
merged in r137

Original comment by ibrahim....@gmail.com on 11 Jan 2009 at 1:35