cdfa / AutoSetupLongTapFreeze

Script for Lightning Launcher that automatically sets up app freezing on any app in a container. See http://www.lightninglauncher.com/wiki/doku.php?id=script_autosetupappfreeze for more info
4 stars 0 forks source link

Compatibility with LL v14? #10

Closed JardaG closed 7 years ago

JardaG commented 7 years ago

Not yet tested, but need to know - will it works?

cdfa commented 7 years ago

Not yet. There's a bug in LL that makes it impossible to revert the container eventhandler. I'll comment again when it's fixed.

cdfa commented 7 years ago

The bug is fixed and a new version is uploaded. If you have any ideas for triggers for the uninstall everywhere function please tell me, because I had to drop this functionality. (See changelog)

JardaG commented 7 years ago

Today I installed LL v14 (r2825) and ASLTF v1.8, and it crash LL when try to run/install script. :(

JardaG commented 7 years ago

After crashed install I can freeze/unfreeze apps, but every time it says "At line 291: ReferenceError: "log" is not defined." and buttons "view script", "disable", "ok".

cdfa commented 7 years ago

I got this too today and it's partly my fault for leaving debugging code in, but it is also a bug introduced in the stable ll14 released, as I'm pretty sure it worked in the last beta (14b7). I will notify Pierre about the bug and let me know if you want me to upload the version without the debug code so you can use it in the latest beta

JardaG commented 7 years ago

Thx for quick reply. Waiting for results. Please do not publish debug code at LL script page. Hope you can also repair uninstall everywhere. I have 17 folders on main screen...

cdfa commented 7 years ago

Uploaded a hotfix for LL14. Tell me if you have any other problems

JardaG commented 7 years ago

Thx for fast update! :) Install now works well, (un)freezing too, but uninstall still cause LL crashing, is it fixable?

cdfa commented 7 years ago

that's weird, i didn't have any uninstall issues on my device. Could you send me a template or backup of your setup, so i can try to fix it?

JardaG commented 7 years ago

Probably fixed, when script updated to v1.8.1 and then uninstall then I got the LL crash, but then every install/uninstall works well. Tested with backup. Do you want send it? How? Now script works like a charm, great! Thank you a lot! :))

cdfa commented 7 years ago

ah okay, then me examing your setup is not needed i think. I will post here again when the bug in LL I had to workaround is fixed.

JardaG commented 7 years ago

Ops, another problem, it still showing toast "This item doesn't launch an app!" and never timeout... I got this toast every time when I leave App Drawer back to LL main screen. Script probably refresh all icons and found some issues...

JardaG commented 7 years ago

Ohhh, god, LL crash on all folders when I uninstall a script... :( Going thru this...

cdfa commented 7 years ago

oh right, i know where the toast is coming from and will try to fix it in a minute. What do you mean excactly by uninstalling the script? Just deleting it from the script editor? Because somehow that doesn't cause any error with me. If you have any ideas for triggers for the uninstall everywhere action i will reimplement that one as well, which should help i think

JardaG commented 7 years ago

Well, try to fix it. And I also found the reason, I forgot an old icon on desktop which now point to wrong target because I manually rename *.app file in system to disable it totally (some phone producer sniffing app). About uninstall - because autosync now work (before not) I assume, after updating to LL14, the updated script probably need to reinstall in ALL folder manually, so every time when I tried to start "uninstall" in folder I got LL crash, then LL restarts and I run ASLTF to "install" script again. Now it looks stable and autosync works. :)

cdfa commented 7 years ago

Aha, okay, do you still get the toast when you resume the app now? And actually only very few script updates would need a reinstall. If it does, I'll put it in the patch notes and otherwise just try without reinstalling first. If you don't get errors it's fine, else reinstall anyway.

JardaG commented 7 years ago

No, I did not got the toast now, I removed the wrong icon. Ok, good idea to inform user about script reinstalling after update. Hmm, now some another item ad desktop cause showing neverending toast...

JardaG commented 7 years ago

Please show some item identification in toast which object cause failure, I can't identify it now.

cdfa commented 7 years ago

Yes i was just gonna suggest that. I'll make the change in a bit

cdfa commented 7 years ago

Done. I couldn't really test it, because i don't have such item in my test environment, but it should work.

JardaG commented 7 years ago

Not sure it work, it say "null doesn't launch an app!"...

cdfa commented 7 years ago

oops, you're right. 1.8.1.2 out now!

JardaG commented 7 years ago

YES! :) It is "Work Chat" shortcut created for Evernote. How to create - launch Evernote, from left menu select "Work Chat", then open user menu "..." on right and select "Add to home screen". Is this generally identifiable object to ignore it?

JardaG commented 7 years ago

But I did not understand why this toast never timeout and is still on screen... Every time I must kill LL manually co clear this.

cdfa commented 7 years ago

I don't know that either. I think I will just change it so the toast only pops up when the user is trying to freeze an item and not when the container is trying to sync it's items.

JardaG commented 7 years ago

Interesting thing... I disabled autosync and now using "Sync frozen-state" menu item (at LL home screen). Toast never showed for first try of "Sync frozen-state", (after LL restarted for clear old toast), but then every time. Also I always seen SuperSU toast, so maybe conflict of toasts over itself make timeout issue...?

JardaG commented 7 years ago

I'm sure that autosync show toast info, for example when I leave App Drawer, as I wrote before.

cdfa commented 7 years ago

I don't think toast collisions could be the problem, because android has a very nicely working system for that. It might be the fact that syncs are not done in the GUI-thread, but i'm not sure. Anyways you shouldn't get any toast notification when syncing anymore in 1.8.1.3

JardaG commented 7 years ago

Great! :) Thx a lot! =)