search

cdfarrow / flextools

Python scripting utility for SIL FieldWorks Language Explorer (FLEx)
Other
15 stars 5 forks source link

Allow double-click of modules that modify #18

Closed rmlockwood closed 1 year ago

rmlockwood commented 2 years ago

Right now, if you double-click a module that is set to modify the database, you get an error to use RunModify. Couldn't FLExTools know that it's a modify module and bring up the 'Are you sure' messagebox at that point rather than an error? I've done this countless times and I have a user who asked for this kind of fix to be made.

bbryson commented 2 years ago

I agree.

I also wish there were an option to tell it not to ask me "Are you sure?" every time. Or is that ill-advised? Maybe make it as an "easter egg"? That is, we have to know the magic incantation.

cdfarrow commented 2 years ago

The reason it behaves like this is because of the "Dry run"/"Do it for real" model of operation. The default operations (double-click, enter, and the standard Run buttons) are activating the dry run mode. It is like a safety switch, and the error message is to prompt the user to release the safety guard by using the Shift key or use the Modify buttons. See #19 for a suggested improvement that addresses this.

cdfarrow commented 1 year ago

I also wish there were an option to tell it not to ask me "Are you sure?" every time. Or is that ill-advised? Maybe make it as an "easter egg"? That is, we have to know the magic incantation.

You can now specify "warnonmodify = False" in the ini file to do this. I might make it a toggle in a menu at some point.

bbryson commented 1 year ago

I’m happy with an .ini file solution. If we try it out and feel we really want it in a menu, we can ask for that, but for now, this gives us a chance to experience this option and see if we really wanted it or not.

Thanks!

-Beth

On Mar 19, 2023, at 10:59 PM, cdfarrow @.***> wrote:

I also wish there were an option to tell it not to ask me "Are you sure?" every time. Or is that ill-advised? Maybe make it as an "easter egg"? That is, we have to know the magic incantation. You can now specify "warnonmodify = False" in the ini file to do this. I might make it a toggle in a menu at some point.

— Reply to this email directly, view it on GitHub https://github.com/cdfarrow/flextools/issues/18#issuecomment-1475583764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA62JLG4EUJX5CKVTLWKZDLW47I25ANCNFSM57GZCVOA. You are receiving this because you commented.