cdfoundation / tekton-helm-chart

CDF official helm chart for Tekton
Apache License 2.0
53 stars 49 forks source link

Move crd to crds dir #32

Closed Transmitt0r closed 1 year ago

Transmitt0r commented 2 years ago

PR for #31

tomhobson commented 1 year ago

Hey @Transmitt0r, to do this you'd have to edit the makefile to swap them around. This pull completely automagically so manually editing the files doesn't persist the changes

Transmitt0r commented 1 year ago

@tomhobson hey, this PR is now 9 months old and I now understand a lot better why the CRD's are not part of the CRD directory (resources in the crd dir do only get applied once and then not updated, this would be confusing for people that use this chart). I'm still slightly annoyed that this means that this chart can't be used as a direct Helm-dependency, but applying CRD's should probably be done in a separate step from your application anyways since they are cluster-scoped resources.