Amend/tekton helm charts

cdfoundation / tekton-helm-chart

CDF official helm chart for Tekton

Apache License 2.0

53 stars 49 forks source link

Amend/tekton helm charts #47

Closed mentlak0 closed 1 year ago

mentlak0 commented 1 year ago

Issue with tekton-helm-chart deploying a tekton-pipelines-resolvers ns that is not necessary for tekton-pipelines to work.

Amending makefile to render charts with yq in order to:

remove tekton-pipelines-resolvers-ns.yaml (stop deployment of the ns)
insert '{{ .Release.namespace }}' in subject.namespace to overwrite tekton-pipelines-resolver manifest for crb
delete namespace from tekton-pipelines charts to allow correct install with helm
make fetch v0.42.0 applied

mentlak0 commented 1 year ago

/cc @tomhobson @msvticket

mentlak0 commented 1 year ago

I can't see where we are combining the service accounts here

As discussed. I think the combining of the service accounts is incorrect as better to have the two different service accounts that work with the services they are bound to. resolvers and controller. So fixing the namespace they are deployed to, fix the issue.

tomhobson commented 1 year ago

fixes: https://github.com/cdfoundation/tekton-helm-chart/issues/19

tomhobson commented 1 year ago

/cc @msvticket

tomhobson commented 1 year ago

approving and merging as k8s 1.24 is becoming unsupported at the end of this month