Removing missing print - Githubissues

cdgriffith / Box

Python dictionaries with advanced dot notation access

https://github.com/cdgriffith/Box/wiki

MIT License

2.61k stars 106 forks source link

Removing missing print #139

Closed rochacbruno closed 4 years ago

rochacbruno commented 4 years ago

removing a missing print call

There was a print outputting keys on dynaconf, so it took me some time to understand that this was coming from box.

coveralls commented 4 years ago

Coverage decreased (-0.0002%) to 99.875% when pulling 569f28c904edbd35b95100537fe6796c7c071724 on rochacbruno:patch-1 into ec6cc77390a2b6dbdbc11d5c482f06626c8cd4cb on cdgriffith:master.

cdgriffith commented 4 years ago

Apologies for apparently leaving that in somehow, I will try my best to get this released tonight when home. Thank you for the PR!

rochacbruno commented 4 years ago

@cdgriffith on dynaconf I am using pre-commit on CI and there is this hook which identifies those kind of debug statements https://github.com/rochacbruno/dynaconf/blob/master/.pre-commit-config.yaml#L26

Do you think it is a good idea to adopt pre-commit on box? I can prepare a PR

cdgriffith commented 4 years ago

I have not heard of that before, that would be a great addition!