Remove duplicate __recast call

cdgriffith / Box

Python dictionaries with advanced dot notation access

https://github.com/cdgriffith/Box/wiki

MIT License

2.61k stars 106 forks source link

Remove duplicate __recast call #187

Closed JacobHayes closed 3 years ago

JacobHayes commented 3 years ago

recast was being called twice - once in setattr and again in setitem. Since setattr defers to setitem, we don't need to call in setattr__. Also, some of the "is frozen" checks weren't aligned between the two methods (so fixed to make them match).

JacobHayes commented 3 years ago

Tests seem good, any ideas on the coveralls issue @cdgriffith? Sorry for the noise with #186, thought it might have been due to the initial master target branch but seems not.

cdgriffith commented 3 years ago

meant to leave that reply in this PR about coveralls, whoops. But tests pass and think coveralls has to do with https://github.com/lemurheavy/coveralls-public/issues/1493