search

cdgriffith / FastFlix

FastFlix is a free GUI for H.264, HEVC and AV1 hardware and software encoding!
https://fastflix.org/
MIT License
1.12k stars 55 forks source link

"Remove Metadata" only removes video metadata for Rigaya's hardware encoders #330

Closed wynterca closed 2 years ago

wynterca commented 2 years ago

The "Remove Metadata" option doesn't seem to do anything the tool tip says removes titles etc? I am usually encoding with NVencC, maybe that is not supported with that particular encoder?

cdgriffith commented 2 years ago

For the NVencC (and all rigaya's encoders) it will pass in --video-metadata clear vs --video-metadata copy (their docs). I do need to fix that tool tip, as it doesn't remove titles as there is the "Title" field on the left hand side now to set / unset that.

I just tried it, and seems to clear the Video Language, but doesn't clear container metadata (which is cleared when that option is selected with ffmpeg) Looks like I need to also provide just --metadata clear which I missed. Thanks for pointing it out!

cdgriffith commented 2 years ago

Updated to provide both in https://github.com/cdgriffith/FastFlix/releases/tag/4.9.0, thanks for opening the issue!