cdgriffith / FastFlix

FastFlix is a free GUI for HEVC and AV1 encoding, GIF/WebP/AVIF creation, and more!
MIT License
1.1k stars 55 forks source link

Custom CRF is broken on MacOS #52

Closed 2600box closed 3 years ago

2600box commented 3 years ago

When trying to set a custom CRF, this is the problem I encounter. I cannot enter text into the custom text box (where it is 30 in the screenshot).

Works normally if I set to 18.

Screen Shot 2020-08-27 at 18 24 27
Traceback (most recent call last):
  File "/Users/glacier/.local/pipx/venvs/fastflix/lib/python3.8/site-packages/fastflix/plugins/hevc/settings_panel.py", line 206, in <lambda>
    self.widgets.crf.currentIndexChanged.connect(lambda: self.mode_update())
  File "/Users/glacier/.local/pipx/venvs/fastflix/lib/python3.8/site-packages/fastflix/plugins/hevc/settings_panel.py", line 227, in mode_update
    self.main.build_commands()
  File "/Users/glacier/.local/pipx/venvs/fastflix/lib/python3.8/site-packages/fastflix/widgets/main.py", line 815, in build_commands
    settings = self.get_all_settings()
  File "/Users/glacier/.local/pipx/venvs/fastflix/lib/python3.8/site-packages/fastflix/widgets/main.py", line 808, in get_all_settings
    settings.update(**self.video_options.get_settings())
  File "/Users/glacier/.local/pipx/venvs/fastflix/lib/python3.8/site-packages/fastflix/widgets/video_options.py", line 51, in get_settings
    settings.update(self.current_settings.get_settings())
  File "/Users/glacier/.local/pipx/venvs/fastflix/lib/python3.8/site-packages/fastflix/plugins/hevc/settings_panel.py", line 273, in get_settings
    settings.crf = int(crf.split(" ", 1)[0]) if crf != "Custom" else int(self.widgets.custom_crf.text())
ValueError: invalid literal for int() with base 10: '16Custom'
cdgriffith commented 3 years ago

Oh hey, I actually just fixed this in 2.4.1 and didn't notice a bug report was open for it. I'm leaving it open for the moment just to remember to add attribution with next release.

cdgriffith commented 3 years ago

Attributed in 2.5.0