search

cdgriffith / FastFlix

FastFlix is a free GUI for HEVC and AV1 encoding, GIF/WebP/AVIF creation, and more!
MIT License
1.07k stars 54 forks source link

Inconsistencies in NVENC capitalization and typos #539

Closed L0Lock closed 1 month ago

L0Lock commented 6 months ago

FastFlix Version: 5.6.0
Operating System: Windows 11

Describe the bug

It's a two-step issue. First being, Rigaya's NVENC all seem to have a doubled letter typo at the end:

image

Secondly, there is no consistency in the capitalization of NVENC in the codecs list. It would look tidier if it was written the same all the time.

IMHO it would make the most sense to just use the official one. In both official and many third party documentations, Nvidia's encoder is named NVENC in full cases:

Sometimes we also find with PascalCase: NvEnc, which also makes sense as it's the short of "Nvidia Encoder", but it's unofficial. Other writings such as lower case or Nvenc are not as relevent IMHO.

cdgriffith commented 6 months ago

This is to make the clear distinction between the NVIDIA encoder itself, and NVEncC which is what rigaya's app's executable is named. As the items in the parentheses are shorthand encoder names.

For example the windows download file is named NVEncC_7.40_Win32.7z