search

cdgriffith / FastFlix

FastFlix is a free GUI for H.264, HEVC and AV1 hardware and software encoding!
https://fastflix.org/
MIT License
1.13k stars 55 forks source link

HDR2SDR double tonemapping in Rigaya NVENC and QSV Encoders #605

Closed Darksyderz closed 1 month ago

Darksyderz commented 1 month ago

Hello <3 huge lover of fastflix, found this after trying handbrake and found it much easier for most things. been having issues with HDR2SDR tonemapping though, specifically with the Rigaya set of encoders. i usually use reinhard TMPing due to its overall look. when using the rigaya encoders either compiled from source or precompiled. i seem to have a double tonemapping issue causing the end footage to be absolutely garbled. enclosed below are the commands it outputs that are problematic as well as screenshots showing the non default nvenc encoder, qsv encoder and the default nvenc option with HDR removal and reinhard tonemapping shown. any help would definitely be appreciated as Rs encoders do a faster job overall with more control.

Content with personal information removed

cdgriffith commented 1 month ago

Hello @Darksyderz can you please use online example files such as https://github.com/cdgriffith/FastFlix/blob/master/tests/media/Beverly%20Hills%20Duck%20Pond%20-%20HDR10plus%20-%20Jessica%20Payne.mp4 to test with. Or from https://4kmedia.org/

Making sure I understand, the issue is happening on in both Rigaya's encoders but not ffmpeg's built in nvenc one?

cdgriffith commented 1 month ago

Acutally found out where the error in code this is happening. Will fix, thanks for raising the issue!

Darksyderz commented 1 month ago

wow thank you for the super quick response <3 much love and appreciation for all the work you do my friend.