Adding mime types for Office Open XML format

cdgriffith / puremagic

Pure python implementation of identifying files based off their magic numbers

MIT License

161 stars 34 forks source link

Adding mime types for Office Open XML format #9

Closed jiel closed 7 years ago

jiel commented 7 years ago

I added mime types for .docx .xlsx .pptx

coveralls commented 7 years ago

Changes Unknown when pulling 3b1a8a4f2448d3c41f4d503ab9ca252389fb802c on jiel:develop into on cdgriffith:develop.

pep8speaks commented 7 years ago

Hello @jiel! Thanks for updating the PR.

In the file puremagic/__main__.py, following are the PEP8 issues :

Line 40:1: E305 expected 2 blank lines after class or function definition, found 1 Line 46:80: E501 line too long (80 > 79 characters)

In the file test/test_common_extensions.py, following are the PEP8 issues :

Line 45:5: E303 too many blank lines (2) Line 47:17: E225 missing whitespace around operator Line 65:5: E303 too many blank lines (2) Line 67:17: E225 missing whitespace around operator Line 75:5: E303 too many blank lines (2) Line 81:80: E501 line too long (80 > 79 characters) Line 89:80: E501 line too long (82 > 79 characters) Line 135:9: E266 too many leading '#' for block comment

Comment last updated on April 02, 2017 at 21:21 Hours UTC

coveralls commented 7 years ago

Changes Unknown when pulling feea968718735d49a580f1966e3592e76be38961 on jiel:develop into on cdgriffith:develop.

coveralls commented 7 years ago

Changes Unknown when pulling 76e9087678c6c18eb85aab0fefde4d8c6fb9c350 on jiel:develop into on cdgriffith:develop.

coveralls commented 7 years ago

Changes Unknown when pulling 76e9087678c6c18eb85aab0fefde4d8c6fb9c350 on jiel:develop into on cdgriffith:develop.

coveralls commented 7 years ago

Changes Unknown when pulling 76e9087678c6c18eb85aab0fefde4d8c6fb9c350 on jiel:develop into on cdgriffith:develop.

coveralls commented 7 years ago

Changes Unknown when pulling 76e9087678c6c18eb85aab0fefde4d8c6fb9c350 on jiel:develop into on cdgriffith:develop.

coveralls commented 7 years ago

Changes Unknown when pulling 76e9087678c6c18eb85aab0fefde4d8c6fb9c350 on jiel:develop into on cdgriffith:develop.

cdgriffith commented 7 years ago

Hi @jiel, thanks for the additions! I will get an authors file up to put you in shortly, then release to PyPI.

jiel commented 7 years ago

hi Chris. Thank you and thanks for taking the time to refactor my naive python code for filename hinting. I've a use case on AWS S3 where I know the original filename but don't have OS access to the file.