search

cdhorn / CardView

A Gramps browseable object view
GNU General Public License v2.0
24 stars 5 forks source link

Show the section titles when sections are collapsed & provide a toggle to show/hide all. #200

Closed fxtmtrsine closed 2 years ago

fxtmtrsine commented 2 years ago

For all cards show the section titles when sections are collapsed & provide a toggle to show/hide all.

When you collapse a section 2022-06-15 15_16_17-main - Tag - Gramps

you get this which I find not very useful.

2022-06-15 15_16_32-main - Tag - Gramps

(originally mentioned in https://github.com/cdhorn/CardView/issues/196#issuecomment-1156003215 )

emyoulation commented 2 years ago

you get this which I find not very useful.

Retaining a header for a collapse would mean that the column width would not collapse with the collapse of its last section. So collapsing would not recover space to widen the other, uncollapsed columns.

Perhaps you can suggest an alternative that does not sacrifice the horizontal space?

cdhorn commented 2 years ago

I disabled the expander wrapper altogether and that does in many ways look and feel cleaner.

The main reason it was added way back for the groups was so in person view I could quickly roll up the children and not have to scroll down when there were multiple spouses and so I had some kind of label for the group.

Perhaps that needs rethinking.

wroldwiedbwe commented 2 years ago

@fxtmtrsine Have to agree looks bad lets avoid MMN in Gramps!

As it stands you can't tab or move around the card views using keyboard shortcut like the reset of Gramps so maybe keyboard shortcuts could be used to toggle sections and like in list views use the context menu to expand or collapse all nodes?

People Tree View - Gramps

Does it bother anyone else that the section titles are repeated inside the section statistics cards? If section titles are to be always shown then you could remove the repeated title.

cdhorn commented 2 years ago

Have to agree looks bad lets avoid MMN in Gramps!

LOL! Had never heard the term.

Does it bother anyone else that the section titles are repeated inside the section statistics cards? If section titles are to be always shown then you could remove the repeated title.

Yeah I agree it's also unnecessary screen real estate. I am going to address it.

What are thoughts on the expanders in the other page views? Similar?

Maybe I should keep them for children in the family groups and phase them out altogether elsewhere.

cdhorn commented 2 years ago

Global -> Display -> Last option on bottom is Group wrapper display mode so people can tailor as they please with 5 modes to select from. Child groups will always have an expander though, but when collapsed will show the group title. Also removed the titles on the statistics cards.

Adding an expand all / collapse all isn't something I personally need so don't plan on spending time on. If someone wants to submit a PR to add it I'd have no problem doing so though.