cdhorn / CardView

A Gramps browseable object view
GNU General Public License v2.0
24 stars 5 forks source link

Discussion on possible improvement to Person card #205

Closed patsyblefebre closed 2 years ago

patsyblefebre commented 2 years ago

@cdhorn Thanks eternally for the addon 👍

I've been using it for about a week on and off and so far only one thing I believe needs to be improved but how I don't know exactly how so I'm raising it here to get some feedback from others.

On the Person card I believe the display and handling of the way the "Parents and Siblings" and "Spouses and Children" (section?) are shown when the person is in more than one family or has had multiple spouses and children should be improved?

I modified my example.gramps file to have above displayed.

cdhorn commented 2 years ago

You're welcome.

Commit 6d333c800e91d63d6ecd48dab51566dee15854fe adds family count to the group label if there are more than one present.

cdhorn commented 2 years ago

Let me know if you think the label change is sufficient. I could add options to not expand siblings/children if needed when rendering but I think the label should do.

Also if any other ideas have come to mind.

patsyblefebre commented 2 years ago

Let me know if you think the label change is sufficient.

Yes that did the job well.

Thank you