cdhorn / CardView

A Gramps browseable object view
GNU General Public License v2.0
22 stars 5 forks source link

Not reproducible... cannot unload tree #214

Open emyoulation opened 1 year ago

emyoulation commented 1 year ago

I was having a problem where I could not close a Tree with the CardView installed. (Made the mistake of not capturing the error message before re-starting Gramps and trying to re-produce from scratch.) It was claiming that some about not being able to do a specific task within another of those tasks. (I wonder if it was related to a timing where the task was interrupted and athem timing was incomplete. This was in my own large tree. Since Gramps refused to close that tree and load the Example.gramps tree, I suspected a transient problem.)

Eventually, I had to turn off the Preferences features to reload the Tree upon start and backup on exit. Then killed Gramps and restarted. The following error is unrelated to the above problem. However, it indicates a Stats error.

render_page: statistics 0.10900115966796875
render_page: dashboard 0.0630033016204834
stats collected: 5.033998012542725
render_page: dashboard 0.004999637603759766
render_page: statistics 0.13599872589111328
stats collected: 4.5009989738464355
render_page: dashboard 0.1719985008239746
render_page: statistics 0.009000062942504883
Warning: GlobalHistory: Signal emitted with wrong arg types: active-changed
         from: file: C:\Users\DistrictSupport\AppData\Roaming\gramps\gramps51\plugins\RestoreHist\restorehist.py
               line: 59
               func: clear_history
    arg passed was: ['Person', 'd24aa580efe32bd4323ab6687e3'], type of arg passed <class 'list'>,  type should be: <class 'tuple'>
render_page: statistics 0.38399529457092285
Traceback (most recent call last):
  File "C:\Users\DistrictSupport\AppData\Roaming\gramps\gramps51\plugins\CardView-master\src\view\services\service_statistics_worker.py", line 46, in <module>
    from gramps.gen.datehandler import get_date
ModuleNotFoundError: No module named 'gramps'
cdhorn commented 1 year ago

So this is issue with RestoreHist plugin not understanding the new global history. When the history is saved the tuples are converted to list, and retrieved the list needs to be converted back to a tuple before emitting the signal. If I recall I submit a PR for it not sure Paul ever looked at it. Take a look a RestoreHist/hist_save.ini and you'll see the linear object histories for Person, Family, etc and then the Global one.

It would be nice if the history was saved and restored from database metadata and not an external ini as would then track with the database.