cdhorn / CardView

A Gramps browseable object view
GNU General Public License v2.0
24 stars 5 forks source link

Gramps 5.2 testing #239

Open TheMihle opened 9 months ago

TheMihle commented 9 months ago

For fun I wanted to see if this plugin would work on Gramps 5.2 without any changes. So I tried to install it, and go in to the files where I found reference to "5.1" (.gpr.py files) and change them to 5.2.

The plugin seem to be working mostly fine from what I have seen until now, but there is two things I have noticed:

  1. The columns doest seem to auto expand to fill the width anymore.
  2. Tags view works fine in Card view, but in standard "Tags" view it creates an error, not sure its related to this mod or not. I may further test with disabling the plugin to see.
emyoulation commented 9 months ago

I vaguely recall a bug report. There was another view (or dialog table) that had a similar problem. It seemed to be related to the the way 5.2 preferences started saving resized columns instead of re-initializing to defaults.

There was a problem if the width of the rightmost was always simply loaded from preferences. Instead it needed to take the greater of: that value or the calculated remainder of the windows width.

AnneLaureF commented 7 months ago

I also tried it, changing the gramps target version to 5.2 in all the .gpr.py files. It mostly works (the exceptions I sometimes get happened in 5.1 already)

Here is a very basic patch so that the tagview doesn't crash anymore:

diff --git a/src/tagview.py b/src/tagview.py
index b71e4f8..f127f39 100644
--- a/src/tagview.py
+++ b/src/tagview.py
@@ -225,6 +225,9 @@ class TagView(ListView):
         """
         return None

+    def get_config_name(self):
+        return __name__
+
     def get_stock(self):
         """
         Use the gramps-tag stock icon
cdhorn commented 7 months ago

Switched tip of master over to 5.2. Thanks @AnneLaureF I included that as well.

cdhorn commented 7 months ago

@TheMihle what OS are you running on as I'm not seeing that on Fedora at least at first glance?

TheMihle commented 5 months ago

@TheMihle what OS are you running on as I'm not seeing that on Fedora at least at first glance?

@cdhorn I didnt see this before now, sorry.

I am on windows. I installed your updated version. If you are talking about the not auto expanding thing, Here is some screenshots: In 5.2 it looks like this: image in 5.1.5 it looked like this: image

Aka its not auto width anymore.