Add post on CDI Lite extension

cdi-spec / cdi-spec.org

Sources for cdi-spec.org

18 stars 23 forks source link

Add post on CDI Lite extension #41

Closed antoinesd closed 3 years ago

mkouba commented 3 years ago

I also have few suggestions to tweak the CSS for a blogpost:

add font-weight:bold; to h4 (it's quite invisible ATM)
modify .post .meta { margin-bottom: 10px; } to .post .meta { margin-bottom: 2em; }
add padding: 2em 10em 2em 10em; to .panel-body
use p { margin: 0.8em 0 0.5em; }

And maybe more...

manovotn commented 3 years ago

I have added a commit doing a few rewords and addressing some of Martin's comments. Please do take a look.

manovotn commented 3 years ago

I have tried altering the styles as Martin suggested (it's part of the PR now) only to figure out that my IDE extension won't use it and I don't have correct Ruby setup to locally test it. @antoinesd would you please check out the PR and build it locally to see if the formatting is OK and change it if needed?

manovotn commented 3 years ago

TODOs should now be gone and I have specified the feedback to be a GH issue against CDI repo with given label.

antoinesd commented 3 years ago

Just republish the post in staging with all changes

mkouba commented 3 years ago

@antoinesd I can't see any CSS changes...

antoinesd commented 3 years ago

@mkouba all CSS changed you suggested are there. h4 was the only missing