search

cdibbs / language-jison

Jison syntax definition for the Atom editor and Github linguist.
MIT License
6 stars 2 forks source link

Malformed rules cause poor highlighting on GitHub.com #21

Open maxbrunsfeld opened 4 years ago

maxbrunsfeld commented 4 years ago

These two rules contain a patterns property, but no end property:

These rules are not valid, because they cause the highlighter to push a new rule onto its stack which can never be popped off.

GitHub's engine used to allow this, but now it does not. See also https://github.com/textmate/textmate/pull/1437.

nwhetsell commented 4 years ago

@maxbrunsfeld Thanks for getting to the bottom of this!