search

cdibbs / language-jison

Jison syntax definition for the Atom editor and Github linguist.
MIT License
6 stars 2 forks source link

Grammar tweaks #8

Closed nwhetsell closed 7 years ago

nwhetsell commented 7 years ago

This pull request:

cdibbs commented 7 years ago

@nwhetsell Looks good against my local grammars. Regarding the spec folder, what do you think about updating the package.json with coffeescript and related dependencies? I am not sure what steps you take to run the language-jison-spec.coffee file. Maybe we can get these tests running in TravisCI. Thanks, again!

nwhetsell commented 7 years ago

what do you think about updating the package.json with coffeescript and related dependencies?

I wouldn’t. I’m pretty sure that what happens is that Atom would download these dependencies in addition to the built-in packages, and this can cause problems. I got bitten by this in https://github.com/nwhetsell/language-csound/issues/1.

I am not sure what steps you take to run the language-jison-spec.coffee file. Maybe we can get these tests running in TravisCI.

I usually just run them within Atom (choose View > Developer > Run Package Specs), but CI is of course much better. I’ll make a pull request for this shortly.