cdiddy77 / react-native-mediapipe

A React Native Camera and Player for MediaPipe applications.
MIT License
5 stars 9 forks source link

Documentation : Configuring to your operating system should be iOS/Android #114

Open cdiddy77 opened 1 month ago

cdiddy77 commented 1 month ago

On the Installation page we aren't configuring to the OS, we are configuring to the target device OS, which is either iOS/Android

image

This screenshot shows that you are using "Windows | macOS" but those development OSs aren't relevant. The code that you need to set up needs to be set up for either android or iOS.

And as an aside, I don't think this is a great use of tabs, because if developers want to build an app for react native, they would most often setup both for android and for ios. So it would be best to have both sets of instructions visible.

The tabs thing is more useful when the user is using one or the other, as in npm | yarn.

michellrodriguez08 commented 4 weeks ago

would it be okay to that even if the documentation gets longer/confusing?