search

cdidier / irssi-xmpp

irssi-xmpp is an irssi plugin to connect to the Jabber network.
GNU General Public License v2.0
69 stars 22 forks source link

Set correct level for public messages #28

Closed simmel closed 5 years ago

simmel commented 7 years ago

The levels are set in an order and first matching wins.

Before this patch the level NO_ACT was sent when someone sent a message to a chatroom.

cdidier commented 7 years ago

Are you sure this fixes anything at all? For me level is still assigned with the same value.

simmel commented 7 years ago

How do you see that? Indeed with linebuffer.pl's /dumplines -levels I see the same level (PUBLIC that is) with or without this patch BUT with this patch the activity_msg_level sometimes trigger. It's very intermittent, sadly.

But all things considered, this was the only level variable with NO_ACT and NOHILIGHT first.

Sadly I won't be able to debug this right now. If you have time please investigate otherwise I will do it in the beginning of december.

simmel commented 7 years ago

Ah, I think I got something. When the current window is a channel1 and someone types in channel2 I get activity for channel2. But if I'm in the status window or a query I don't get activity for channel2.

Do I make sense?

ailin-nemui commented 6 years ago

technically this is not possible since the bits are the same just like "a+b == b+a"

simmel commented 6 years ago

Mkay, must be something else then. Sadly I don't use irssi-xmpp anymore on a daily basis and I can't remember what it was.

On Mon, 2018-09-24 at 02:22:16 -0700, ailin-nemui wrote:

technically this is not possible since the bits are the same just like "a+b == b+a"

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/cdidier/irssi-xmpp/pull/28#issuecomment-423917844