search

cdimascio / openapi-spring-webflux-validator

🌱 A friendly kotlin library to validate API endpoints using an OpenApi 3.0 and Swagger 2.0 specification
Other
97 stars 13 forks source link

Coroutines support #10

Closed krzykrucz closed 4 years ago

krzykrucz commented 4 years ago

A full coroutines support was introduced with Spring Webflux 5.2, so I thought it would be great this library supported that approach alongside Reactor

cdimascio commented 4 years ago

This is cool. Will review it this weekend. Thanks!

krzykrucz commented 4 years ago

@cdimascio I updated the README, let me know if you have any remarks to that :slightly_smiling_face:

Codacy is failing and I'm not sure what to do with that, as the issues refer to code were I strictly followed the current code style and most of them are false positives, like documenting test classes

krzykrucz commented 4 years ago

@cdimascio Should I try to fix the Codacy somehow or will it be ignored?

cdimascio commented 4 years ago

Ignore the codacy issue

cdimascio commented 4 years ago

Thanks @krzykrucz. Merged

cdimascio commented 4 years ago

@krzykrucz version v3.1.1 contains your coroutines work. it's available now on jcenter, should be on mavencentral shortly

cdimascio commented 4 years ago

@all-contributors add @krzykrucz for dev test and doc

allcontributors[bot] commented 4 years ago

@cdimascio

I've put up a pull request to add @krzykrucz! :tada: