cdimascio / openapi-spring-webflux-validator

🌱 A friendly kotlin library to validate API endpoints using an OpenApi 3.0 and Swagger 2.0 specification
Other
97 stars 13 forks source link

Add request to ErrorHandler #33

Closed magro closed 1 year ago

magro commented 2 years ago

So that the error handler can use information of the request for handling the error, e.g. to log the request uri or some headers.

Note that this is a binary incompatible change (consider to bump the major version)! Reasoning: Trying to achieve this change in a binary compatible manner is considered to be adding too much (unnecessary) code, compared to how easy it is for library users to handle this change. Additionally, only users with a custom error handler would be affected.

magro commented 2 years ago

Ping @cdimascio 😊

magro commented 2 years ago

Another ping @cdimascio :wave:

magro commented 2 years ago

Yet another ping @cdimascio :thinking:

magro commented 2 years ago

Again, @cdimascio :wave:

magro commented 2 years ago

Hey @cdimascio, me pinging again :-)

cdimascio commented 2 years ago

@magro if we make request the last parameter in the list with a default value are we able to maintain backward compatibility?

cdimascio commented 1 year ago

this is available in the latest version 4.1.0