search

cdinger / scenic-oracle_adapter

An Oracle adapter for Thoughtbot's scenic gem
MIT License
6 stars 5 forks source link

Pass no_data keyword arg for update_materialized_view #13

Closed machinehum closed 1 year ago

machinehum commented 1 year ago

Scenic expects a 'no_data' keyword arg for update_materialized_view. Accept this arg, and pass it to create_materialized_view.

cdinger commented 1 year ago

Thanks, @machinehum!

This PR has failing specs because lib/scenic/adapters/oracle.rb line 42 is not using no_data as a keyword argument when calling create_materialized_view. Could you update that?

CI should have caught this, but I didn't have it enabled for PRs for some reason. That was hopefully fixed by 1199a6b2bea6434d7d437e06e8c06c0fc39df8fe and should run on your updates.

machinehum commented 1 year ago

Done!

cdinger commented 1 year ago

Thanks @machinehum! Specs passed locally for me. The CI failure on this PR is just due to me not knowing what I'm doing with actions.

cdinger commented 1 year ago

This fixes #12