cdinger / scenic-oracle_adapter

An Oracle adapter for Thoughtbot's scenic gem
MIT License
6 stars 5 forks source link

Refine `view_dependencies` query to return user-conrolled objects #19

Closed whit0694 closed 6 days ago

whit0694 commented 1 week ago

Closes #18

As mentioned in https://github.com/cdinger/scenic-oracle_adapter/issues/18#issuecomment-2206657472 this updates the query so that it only returns a dependency if it exists in user_objects. So dependencies such as user_scheduler_jobs or other Oracle-controlled objects are excluded.

whit0694 commented 1 week ago

This should be done. Just waiting for tests to run, then I'll rebase.

https://github.com/cdinger/scenic-oracle_adapter/pull/19/commits/c75af155431604a53a87eef8e708c1e6701d276f sneaks in one more minor tweak. Like I said, it's a weird edge case. But it's definitely one we have!

whit0694 commented 1 week ago

Tests pass.

cdinger commented 6 days ago

Thanks again, @whit0694!