Closed drewcdisc closed 1 month ago
@EMuhlbradt @czwickl : while updating the CPT mapping I found another inconsistency that you can take care of: StudyDesign trialIntentTypes indicates that it uses codelist C66736 - Trial Intent Type Response, while the codelist URL refers to C124307: Treatment Intent. I believe the first one is correct. Furthermore, I wonder whether trial Intent type should not be singular instead of plural. The mapping to CPT indicates only one to be filled.
@BSnoeijerCD @dih-cdisc @czwickl see the attached for the full list of changes DDF_417.xlsx
Furthermore, I wonder whether trial Intent type should not be singular instead of plural. The mapping to CPT indicates only one to be filled.
As we discussed yesterday, SDTM TS domain allows for multiple values, hence why USDM allows multiple. Note in IG?
Furthermore, I wonder whether trial Intent type should not be singular instead of plural. The mapping to CPT indicates only one to be filled.
As we discussed yesterday, SDTM TS domain allows for multiple values, hence why USDM allows multiple. Note in IG?
Yes. Added this information to IG - CPT mapping of the CPT Primary Purpose variable.
@BSnoeijerCD @dih-cdisc @czwickl see the attached for the full list of changes DDF_417.xlsx
In general/summary: if all other items have Study added then adding that would indeed make it indeed more consistent. Otherwise, I would leave it as is since it is not included in class and or relationship names. I would not add clinical to the proposed changes of preferred terms as this can make it too restrictive and confusing.
@BSnoeijerCD @dih-cdisc @czwickl see the attached for the full list of changes DDF_417.xlsx
- Not sure why activity should be changed to Study Activity as class name and relationship to class does not include Study. Also Preferred term change to "Clinical Study Activity Label" might be seen as too restrictive as it might be other activities then clinical activities that are presented in the Schedule of activities.
- Same for endpoints -> not including study there.
- For element - design is included now while this is not the case for endpoints for example. Not sure why it is needed.
- Encounters can be different from clinical encounters -> Can be an entry of a PRO or call to check whether drugs are taken for example. So I think clinical makes it too narrow.
- Same for eligibility Criteria => not sure why study needs to be added.
In general/summary: if all other items have Study added then adding that would indeed make it indeed more consistent. Otherwise, I would leave it as is since it is not included in class and or relationship names. I would not add clinical to the proposed changes of preferred terms as this can make it too restrictive and confusing.
@BSnoeijerCD look at the changes in the context of the whole CT, e.g. for Activity, not the label preferred term is "different" in style to that of name and description.
OK. @EMuhlbradt @czwickl Then is it's good to be consistent and align with the preferred name for the class itself. Also be cautious with using clinical in the label as it might be confusing.
Activity =>use: Activity or Study Activity (Study Activity is now the class label) AnalysisPopulation => Target Study Population for Analysis is now the class label. So I would adjust that one as well to "Analysis Population" then. StudyEndpoint => Proposed changes are making it consistent. So OK. StudyElement => Proposed change makes it consistent. So OK. Encounter => Can we remove clinical everywhere instead of adding it to label as that might be confusing because the encounter does not have to be a clinical one or does not have to be at the clinic? EligibilityCriterion => Proposed change makes it consistent. So OK.
@EMuhlbradt @czwickl
@BSnoeijerCD @dih-cdisc Here is the updated list of changes to go along with this ticket. 417_2024-07-10.xlsx
@EMuhlbradt @czwickl : thank you. Looks good. a few small issues:
For the rest it is ok
@BSnoeijerCD @dih-cdisc QA issues above fixed and pushed to Github deliverables in 3-4-0 release.
@EMuhlbradt @czwickl
@BSnoeijerCD done and pushed to 3-4-0 release on Github
CT Fixes to make to existing:
Plus any additional ones I find