Open BSnoeijerCD opened 2 months ago
@dih-cdisc @EMuhlbradt @czwickl @ASL-rmarshall : The above reference is the template. See the description here: https://www.ema.europa.eu/en/human-regulatory-overview/research-development/paediatric-medicines-research-development/paediatric-investigation-plans "A paediatric investigation plan (PIP) is a development plan aimed at ensuring that the necessary data are obtained through studies in children, to support the authorisation of a medicine for children. " It clearly refers to multiple studies which means it is the same kind of level as a clinical development plan.
@daveih @ASL-rmarshall @czwickl @EMuhlbradt Based on our discussions yesterday, there are two different ways to include this plan ID concept.
Option 1 is to reuse the identifier class. But as it is more general now that would imply you need to rename it from StudyIdentifier to Identifier:
Option 2 is to create a new class for reference Identifiers (naming tbd). Then we can leave the studyIdentifier class as is:
Although it changes the naming, I believe option 1 is more elegant and and efficient at the end. This makes it also possible to add more identifiers types anywhere in the model if needed.
@BSnoeijerCD I think we'd need scope for reference identifiers too (e.g., to specify EMA for a PIP). I guess there might be an intermediate option 1.5 where:
StudyIdentifier
and ReferenceIdentifier
are both types of Identifier
ReferenceIdentifier
needs a type
studyIdentifier
attribute would probably need a more generic name (e.g., identifierText
as shown, but not highlighted)(Note that I changed the cardinality to indicate that at least one study identifier is required)
@ASL-rmarshall @daveih I agree that identifierScope relationship should also be added for the referenceIdentifier. The inheritance might make sense indeed and aligns with other inheritance parts of the model. That also makes the change smaller for users as the StudyIdentifier class name will not change. However the identifier attribute name and identifierScope reference name still needs to be changed (also removing redundancy as we did in other parts of the model). Adding 'Text' to the identifier name could be confusing as that might imply you want a description instead of a number/letter combination. Though I can see where you are coming from as it now is identical to the class name and id attribute.
@EMuhlbradt @czwickl @dih-cdisc @ASL-rmarshall : As discussed during the scrum today: please see below the updated UML for identifiers:
@EMuhlbradt @czwickl @dih-cdisc @ASL-rmarshall : As discussed during the scrum today: please see below the updated UML for identifiers:
@BSnoeijerCD I cannot open the png file for some reason. Can you send it to me in a different way?
@EMuhlbradt please find below again. It shows in zenhub but not in Github for some reason. I also send it by mail.
Discussed during scrum today: We will change attribute name to text instead of identfierText
@BSnoeijerCD @dih-cdisc @ASL-rmarshall @czwickl please see the sprint 7 new and changes tabs with the proposed semantic changes to support this ticket. DDF.Terminology_Sprint.7.changes_2024-08-02.xlsx
@EMuhlbradt @czwickl : looks good. No comments. I aligned the UML regarding the text attribute and uploaded it to the github now.
@BSnoeijerCD @dih-cdisc @EMuhlbradt @czwickl : if we've renamed identfierText
to text
, is there a reason why we wouldn't rename:
Identifier.identifierScope
to Identifier.scope
and, by inheritance,
StudyIdentifier.identifierScope
to StudyIdentifier.scope
andReferenceIdentifier.identifierScope
to ReferenceIdentifier.scope
, andOrganization.organizationType
to type
?@BSnoeijerCD @dih-cdisc @EMuhlbradt @czwickl : if we've renamed
identfierText
totext
, is there a reason why we wouldn't rename:
Identifier.identifierScope
toIdentifier.scope
and, by inheritance,
StudyIdentifier.identifierScope
toStudyIdentifier.scope
andReferenceIdentifier.identifierScope
toReferenceIdentifier.scope
, andOrganization.organizationType
totype
?
I would not complain :)
@BSnoeijerCD @dih-cdisc @EMuhlbradt @czwickl : if we've renamed
identfierText
totext
, is there a reason why we wouldn't rename:
Identifier.identifierScope
toIdentifier.scope
and, by inheritance,
StudyIdentifier.identifierScope
toStudyIdentifier.scope
andReferenceIdentifier.identifierScope
toReferenceIdentifier.scope
, andOrganization.organizationType
totype
?I would not complain :)
There is no reason not to can change identifierScope to scope. This is in alignment with the rest of the changes we did before.
However, for organizationType we deliberately added 'organization' back to the attribute name in phase 3 because this class is also inherited by researchOrganization and then the meaning of type was changing when organization was not added. Therefore, when adding that part to the model we decided to add organization again to type to be absolutely clear and we could have a type of 'Research Organization'. Back then we also discussed to review this part of the model in phase 4 to make it more applicable to all organizations that might be included in a study design / protocol. See #293 We can then reconsider this part.
@BSnoeijerCD @dih-cdisc 'identifierScope' relationship name changed to 'scope' in CT deliverables in 3-6-0 release.
@BSnoeijerCD @dih-cdisc 'identifierScope' relationship name changed to 'scope' in CT deliverables in 3-6-0 release.
Thank you. I made the corresponding change to the UML.
Pediatric investigational plan number needs to be addressed. It is more a reference than an identifier. See EMA template https://www.ema.europa.eu/en/documents/template-form/paediatric-investigation-plan-pip-key-elements-guidance_en.pdf
Child tickets: