cdisc-org / DDF-RA

This is the repository for all code and documentation for the DDF-RA project.
MIT License
17 stars 1 forks source link

CORE v3+v4 - CT checks consistency [Rules] #452

Open BSnoeijerCD opened 1 month ago

BSnoeijerCD commented 1 month ago

Not all terminology lists specified in the CT spreadsheet are included in core checks yet. A check is needed to have a consistent list of these checks. In case a terminology list is extensible then the check can change to expected to and/or we only do a codelist consistency check. So the text/rules must be updated accordingly.

BSnoeijerCD commented 3 weeks ago

@dih-cdisc @ASL-rmarshall I checked all CT and adapted the rules in case of extensible rules. Now all current CT is included as rules. So we have a complete version for v3.0 as well.

Rules for non-extensible codelists have the format: "An .... must be specified using the ... (C....) XXX codelist." Rules for extensible codelists have the format: "An ... must be specified according to the ... (C....) XXX codelist (e.g. an entry with a code or decode used from the codelist should be consistent with the full entry in the codelist).

@EMuhlbradt @czwickl : Also I noted that the new CT codes are added to the "DDF valid value sets" sheet of USDM_CT.xlsx but not to the "DDF Entities&Attributes" sheet. Furthermore the governanceDate.type relationship has a preferred name to protocol while protocol is replaced and the data may also be applicable to a study design version instead of a protocol. I will make a separate ticket for this which we then can resolve for the next version.