Change address lines to plural

cdisc-org / DDF-RA

This is the repository for all code and documentation for the DDF-RA project.

MIT License

18 stars 1 forks source link

Change address lines to plural #479

Closed BSnoeijerCD closed 1 month ago

BSnoeijerCD commented 2 months ago

Change address lines to plural:

Model -> cardinality + attribute name
CT: change address.line to address.lines
API: change cardinality + attribute name
IG: check updates in UML view/text
Rules: update rule(s) for changed attribute name
Test data: update in test data

BSnoeijerCD commented 1 month ago

Model, CT, IG / views and Rules done. @ASL-rmarshall : can you make the API change?

The new rule has id CHK0238. It is an exact copy of the V3.0 rule CHK0068/DDF0045 (e.g. at least 1 address attribute specified). It only differs in implementation as the final implemented rule specifically addresses the line attribute. Now lines can be plural, this might also have implications for the rule development.

ASL-rmarshall commented 1 month ago

The API change is done.

@dih-cdisc To be consistent with BiomedicalConcept.synonyms, I changed:

line: Union[str, None] = None

to:

lines: List[str] = []

instead of:

lines: Union[List[str], None] = None