Feature/odm2 dev 112 114 formal expression method def

Hi Lex,

Excellent piece of work ... !

I only found a few minor issues, please find them in the review comments on Github.

After having done a "diff" for all the changes, I compared the new version of the schema with the spec on the wiki. This also allowed me to make some corrections to the wiki-spec, mostly typos, adding links, etc..

I also see that with the introduction of "Code" as child element of "FormalExpression", I need to update some of the examples ...

With best regards, Jozef

Lex Jansen ***@***.***> hat am 08.04.2022 22:30 geschrieben:

You can view, comment on, or merge this pull request online at: https://github.com/cdisc-org/DataExchange-ODM/pull/14 Commit Summary

4633dca Add FormalExpression Code and ExternalCodeLib
3f84ece Add MethodSignature to MethodDef

File Changes (3 files)

M schema/ODM-foundation.xsd (21)
M schema/ODM-study.xsd (135)
A test/ODM2DEF_112-114-methoddef.xml (61)

Patch Links:

https://github.com/cdisc-org/DataExchange-ODM/pull/14.patch
https://github.com/cdisc-org/DataExchange-ODM/pull/14.diff

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>

cdisc-org / DataExchange-ODM

Feature/odm2 dev 112 114 formal expression method def #14