Enhancement request: extend is_ordered_set and is_not_ordered_set for accepting arrays (lists)

[JozefAerts]

The current implementation of is_ordered_set and is_not_ordered_set only accepts a single parameter value. This is fine for e.g. checking the order of --SEQ within USUBJID. It does however not allow to e.g. check SEND rule 130 (https://jira.cdisc.org/browse/CORERULES-577): "The values of SESTDTC provide the chronological order of the actual subject Elements. SESEQ should be assigned to be consistent with the chronological order." Or otherwise said: within each subject, SESEQ must be ordered by value of SESTDTC.

I think (but am not 100% sure) that overloading the method to also accept arrays would enable the above.

[nhaydel]

Does the target_is_sorted_by operator not solve this issue: https://github.com/cdisc-org/business-rules/blob/master/business_rules/operators.py#L1054?

[JozefAerts]

I am stilly trying to figure out how "target_is_sorted_by" works. I have tried a few things for rule SENDIG-130, but whatever I try, I get an exception "string indices must be integers". Here is an example snapshot of my code:

[gerrycampion]

A few things:

• @JozefAerts can you place some test data in the sharepoint site so that we can test this rule 130?
• @JozefAerts , I believe this rule needs to distinguish the grouping var from the sorting var by using within. I think the rule should be more like:

• name: SESEQ operator: target_is_sorted_by value:
  • SESTDTC within:
  • USUBJID

• @nhaydel what is the purpose of is_ordered_by vs target_is_sorted_by? I thought is_ordered_by was supposed to handle rules like this. FYI, currently no rules in the editor are using any of these operators or their complements, except the rule in question (130).

[JozefAerts]

Thanks Gerry! I uploaded test files: https://cdisc.sharepoint.com/sites/CORERules/Shared%20Documents/Forms/AllItems.aspx?id=%2Fsites%2FCORERules%2FShared%20Documents%2FunitTesting%2FSENDIG%2FSENDIG130%2Fpositive%2F01%2Fdata&viewid=ecd009a9%2Db73b%2D415b%2D9e41%2Df9d04a69edf4 https://cdisc.sharepoint.com/sites/CORERules/Shared%20Documents/Forms/AllItems.aspx?id=%2Fsites%2FCORERules%2FShared%20Documents%2FunitTesting%2FSENDIG%2FSENDIG130%2Fnegative%2F01%2Fdata&viewid=ecd009a9%2Db73b%2D415b%2D9e41%2Df9d04a69edf4 and adapted the YAML to use "within", but keep getting the same "string indices must be integers" exception. Many thanks! Jozef

[nhaydel]

@gcampion-cdisc is_ordered_by is meant to determine whether or not a target is sorted in ascending or descending order. target_is_sorted_by is meant to check that within certain groups, the target is sorted in ascending or descending order. There is that slight within difference that adds some complexity, hence the two operators. Though I don't see us using is_ordered_by that often

[gerrycampion]

@nhaydel within aside, is it correct to say that is_ordered_by looks at the order (position) of records in a dataset whereas target_is_sorted_by looks at the order of values in a variable relative to the order of values in other variables?

If that is the case, I do see these as distinct operations. If that is not the case, and the only difference is the use of within, then I think these operations should be combined.

[nhaydel]

@gcampion-cdisc that is the case. target_is_sorted_by looks at the order of values in a variable relative to the order of values in another variable. I will provide an example in the next day or so