cdisc-org / cdisc-rules-engine

Open source offering of the cdisc rules engine
MIT License
46 stars 12 forks source link

Rule blocked: CORERULES-1676 (2) #362

Open JDenHerder opened 1 year ago

JDenHerder commented 1 year ago

Related to rule CDISC.ADAMIG.AD0047 Could we use Scope - Data_Structures to include/exclude certain ADAM Data Structures for rule checking?

{ "Datasets": { "Include": [ "ADSL" ] }, "Data_Structures": { "Include": [ "SUBJECT LEVEL ANALYSIS DATASET" ] } }

Links to related JIRA Tickets

https://jira.cdisc.org/projects/CORERULES/issues/CORERULES-1676 Rule Information

Standard: ADAMIG Rule ID: 47 Rule Description: "Variable SITEID should be present in dataset ADSL" Describe the bug

A clear and concise description of what the bug is.

Error returned from Rule Engine

[ { "executionStatus": "execution_error", "domain": "ADVS", "variables": [], "message": "rule execution error", "errors": [ { "error": "An unknown exception has occurred", "message": "Output variables: ['SITEID'] not found in dataset" } ] } ]

Describe the problem Could we use Scope - DataStructure to include/exclude certain ADAM Data Structures for rule checking?

Describe the solution First the Data structure of all ADaM datasets needs to get identified.

JDenHerder commented 10 months ago

The same would be needed for Scope - Subclasses. In addition, for the identification of Data structure and Subclass, we should primarily use define.xml when available. Else we could follow the provided logic with the following additional identification for subclasses:

chowsanthony commented 6 months ago

At today's rule authoring meeting, ADaM rule 630 is another example how class & subclass in scope is needed. In this case: class will be OCCURRENCE DATA STRUCTURE and ADVERSE EVENT for subclass.