search

cdisc-org / cdisc-rules-engine

Open source offering of the cdisc rules engine
MIT License
48 stars 13 forks source link

The engine needs updated error handling for both expected and unexpected #509

Open nhaydel opened 1 year ago

nhaydel commented 1 year ago

Refer to this flowchart for how each error type should be handled: https://miro.com/app/board/uXjVMw7HMLE=/

cfra68 commented 8 months ago

I cannot access the flowchart above, but I mentioned the logging is really unclear. It should be good to have a clear error message and also the applicable ruleid.

[ERROR 2024-02-02 08:12:57,999 - console_logger.py:47] - Error occurred during validation. Error: . Error message: [ERROR 2024-02-02 08:12:58,842 - console_logger.py:47] - Error occurred during validation. Error: . Error message: [ERROR 2024-02-02 08:13:02,928 - console_logger.py:47] - Error occurred during validation. Error: . Error message: [ERROR 2024-02-02 08:13:03,975 - console_logger.py:47] - Error occurred during validation. Error: . Error message: [ERROR 2024-02-02 08:13:05,439 - console_logger.py:47] - Error occurred during validation. Error: 'ARM'. Error message: 'ARM' [ERROR 2024-02-02 08:13:08,490 - console_logger.py:47] - Error occurred during validation. Error: . Error message: [ERROR 2024-02-02 08:13:18,222 - console_logger.py:47] - Error occurred during validation. Error: . Error message: [ERROR 2024-02-02 08:13:23,085 - console_logger.py:47] - Error occurred during validation. Error: 'SEUPDES'. Error message: 'SEUPDES' [ERROR 2024-02-02 08:13:23,583 - console_logger.py:47] - Error occurred during validation. Error: . Error message: [ERROR 2024-02-02 08:13:23,661 - console_logger.py:47] - Error occurred during validation. Error: 'IDVARVAL'. Error message: 'IDVARVAL' [ERROR 2024-02-02 08:13:30,423 - console_logger.py:47] - Error occurred during validation. Error: . Error message: [ERROR 2024-02-02 08:13:33,990 - console_logger.py:47] - Error occurred during validation. Error: . Error message: [ERROR 2024-02-02 08:13:43,053 - console_logger.py:47] - Error occurred during validation. Error: 'RDOMAIN'. Error message: 'RDOMAIN' [ERROR 2024-02-02 08:13:43,200 - console_logger.py:47] - Error occurred during validation. Error: "['DSPTCD'] not in index". Error message: "['DSPTCD'] not in index" [ERROR 2024-02-02 08:13:43,230 - console_logger.py:47] - Error occurred during validation. Error: . Error message: