Alignment output report format XLSX - JSON

cdisc-org / cdisc-rules-engine

Open source offering of the cdisc rules engine

MIT License

46 stars 12 forks source link

Alignment output report format XLSX - JSON #595

Open rradel opened 9 months ago

rradel commented 9 months ago

There seems to be a difference between the output report provided in XLSX and JSON, where the XLSX report seems to have evolved, the JSON report has not. e.g. in the JSON output the datasets are not listed with their timestamp, the labels of the different tabs in XLSX are not the same as the tags used in JSON

SFJohnson24 commented 1 month ago

Adding to this ticket

adding dataset domain into the dataset details of the XLSX report. It is worth noting that some times the results outputs the domain as the dataset in the issue. This was a run of CG0017 with the attached dataset unit-test-coreid-CG0017-positive3.xlsx CORE-Report-2024-07-12T18-35-51.xlsx
updating the json report to be more informative as requested above, dataset names instead of just domains validated in JSON result

mhungria commented 1 month ago

I support this ticket.

mhungria commented 1 month ago

Rule (7).zip

mhungria commented 1 month ago

@SFJohnson24 , as per our meeting today, I added the zip file with the incorrect result identifying the results for a dataset named "CMX" (taken from the dataset's domain name instead of the interpreted dataset name "XI"):

SFJohnson24 commented 1 month ago

the above example demonstrates the need for an updated result JSON--the keys for the result JSON is the domain engine validated but there is no information on the name of the dataset that was run representing that domain. The above screenshot directly adds that name into the results JSON but we should be providing the dataset name as well as the domain for each result entry.

mhungria commented 1 month ago

See https://github.com/cdisc-org/cdisc-rules-engine/pull/771