Closed nhaydel closed 4 months ago
@gerrycampion with regards to your questions:
2 & 3. I will include the latest updates to the engine in this PR and in another PR I will remove the dataframe operators
@nhaydel I'm looking at this: https://github.com/venmo/business-rules/compare/master...cdisc-org:business-rules:master#diff-0bc3d92118ee65c44b126d002359281aa3062be23a4b39ad0fc5444862558365
And I see custom StringType and GenericType operators
@nhaydel I'm looking at this: venmo/business-rules@master...cdisc-org:business-rules:master#diff-0bc3d92118ee65c44b126d002359281aa3062be23a4b39ad0fc5444862558365
And I see custom StringType and GenericType operators
Yes, those are not used by the rules engine and are carryover from forking the business rules repo
@gerrycampion thanks for those fixes!
@gerrycampion i see you reviewed another PR related to dataset abstractions recently. This one is more up to date. I will address those comments here and merge this one once approved