cdisc-org / cdisc-rules-engine

Open source offering of the cdisc rules engine
MIT License
46 stars 12 forks source link

Domain Presence Check vs Dataset Presence check - Missing functionality? Bug? #650

Open mhungria opened 6 months ago

mhungria commented 6 months ago

Based on the documentation and tests I performed, the Domain Presence Check is creating a data frame with one column per domain (JSON label 'domain') in the JSON file with the column value as only one of the potential filename values included; however, there may be multiple filename values, all having the same domain value. Note that in the Datasets tab of the Excel file used as the rule editor input, the Dataset's name is not requested. How is the rule editor transforming the Excel file's Dataset tab to the JSON format used?

Requested to support implementation of FDAB011 and similar types of rules.

See draft rule SD1112 and test data I uploaded to Sharepoint: https://cdisc.sharepoint.com/:f:/r/sites/CORERules/Shared%20Documents/unitTesting/SDTMIG/[SD1112](https://cdisc.sharepoint.com/:f:/r/sites/CORERules/Shared%20Documents/unitTesting/SDTMIG/SD1112?csf=1&web=1&e=SHjIaC)?csf=1&web=1&e=SHjIaC

Results obtained: Rule (2).zip

SFJohnson24 commented 2 months ago

" Note that in the Datasets tab of the Excel file used as the rule editor input, the Dataset's name is not requested. How is the rule editor transforming the Excel file's Dataset tab to the JSON format used?" https://github.com/cdisc-org/conformance-rules-editor/blob/961d5210294cb1abbd487bf20bb79458fd6a772d/src/utils/ExcelDataset.ts#L43 Here is the bit of code that converts the dataset tab to json. It is then matched with the dataset tab using this: https://github.com/cdisc-org/conformance-rules-editor/blob/961d5210294cb1abbd487bf20bb79458fd6a772d/src/utils/ExcelDataset.ts#L151