Iss 83 - Run CORE Validate on Local Unpublished rules

cdisc-org / cdisc-rules-engine

Open source offering of the cdisc rules engine

MIT License

45 stars 12 forks source link

Iss 83 - Run CORE Validate on Local Unpublished rules #674

Closed SFJohnson24 closed 2 months ago

SFJohnson24 commented 3 months ago

added functionality to run unpublished rules with CORE validate CLI with unpublished rule input as yml or json formats. tested with json, yml rules as well as multiple unpublished rules simultaneously. updated readme, added unpublished rule validate test along with accompanying unpublished rule YML file in test/resources

SFJohnson24 commented 3 months ago

I made all changes from the prior review and made a ticket for the cache updater. get_rule as it is currently written is too complex for the flake8 threshold of 10. Any suggestions on clean ways of reducing this? I was going to take the logic in the else portion and make it into it's own function to break things up.

SFJohnson24 commented 3 months ago

I removed references to unpublished as well as splitting get_rules into helper functions behind filters that should work in cases where -r and -lr are both specified, when just one is specified, or neither is specified.

SFJohnson24 commented 2 months ago

@gerrycampion I believe I made all the changes to the specifications we talked about last week