Open gerrycampion opened 9 months ago
For the POC demo, we agreed that an alternative is just to publish the DDF rules temporarily.
To get some yaml exports for testing this, refer to: https://github.com/cdisc-org/conformance-rules-editor/pull/214
While validating the issue I noticed that:
if we run a validation while not using -lr option and a rule id which is not in the scope of the specified standard, the engine throws an error and exits. You can reproduce using the following command:
python3 core.py validate -s sdtmig -v 3.4 -dp tests/resources/COREIssue329/ts-test-dataset-T.json -r CORE-000482 -r CORE-000001
The other case when -lr is used, the engine gives error in case when the mentioned id is not in the specified local rule directory. You can reproduce using the following command:
python3 core.py validate -s sdtmig -v 3.4 -lr tests/resources/datasets -dp tests/resources/COREIssue329/ts-test-dataset-F.json -r CORE-000473
Both cases may be fixed in a single change for removing bug. It is recommended that there should be graceful exception handling implemented here so even if an error occur, the engine keep validating for the other rules and log the errors
I updated the error handling and the associated test (although it does not need a specific -r flag for -lr in the directory to run) and sent this back to review
There are a few options:
I think ultimately we will want to support both options