search

cdisc-org / cdisc-rules-engine

Open source offering of the cdisc rules engine
MIT License
45 stars 12 forks source link

Test for merge supp datasets #693

Open RamilCDISC opened 2 months ago

RamilCDISC commented 2 months ago

I have added the test required to close the connected Issue as mentioned by @SFJohnson24

SFJohnson24 commented 2 months ago

@RamilCDISC the large dataset PR has caused some conflicts, can you resolve them?

RamilCDISC commented 1 month ago

@RamilCDISC the large dataset PR has caused some conflicts, can you resolve them?

I have resolved the conflicts and updated the test and code

SFJohnson24 commented 1 month ago

@RamilCDISC the function you created does seem to be performing the merge properly per the unit testing. I was on your branch and tried to run a debugger validate using EC/SUPPEC as well as DM/SUPPDM datasets from sharepoint. I put a breakpoint() inside your function (which never triggered) as well as inside some of the validate logic. It appears engine is not entering the logic to invoke your function when a supp dataset is provided and thus the merge_supp_dataset never gets called. We may need to check why this is the case.