search

cdisc-org / cdisc-rules-engine

Open source offering of the cdisc rules engine
MIT License
45 stars 12 forks source link

fix bug split dataset-554 #700

Closed ab3263266 closed 1 month ago

ab3263266 commented 1 month ago

fix bug split dataset-554 Add unit testing

ab3263266 commented 1 month ago

Hi @SFJohnson24 , nice catch Are you sure it should shoot twice?, that's a good question, how do we define the split data as one or two data, in the sensitivity of this rule it is defined as Dataset that means it should fire once per dataset, the question is how do you define the split data, I think there is a bit of inconsistency in it, for example here: image We defined as a dataset each file on its own, while under Issue summary and Issue details: image

we treated the entire domain as one, I would love to hear your input