RamilCDISC
commented
1 month ago While reviewing the code I noticed that removing check of 'if missing_keys' will make the engine print the erro message always when -r flag is used. We can notice this if you run the code with log level set as error. I quick ran a validation too, using the folder for rule and dataset from with in the engines code. It prints the error of missing key and exits. Altough the rule mentioned using -r is present in the local directory specified. I ran the following command:
python3 core.py validate -s sdtmig -v 3.4 -r CG0022 -lr tests/resources/CoreIssue363 -d tests/resources/datasets -l error
the if check on line 195 needs an initialized missing_keys value to check truthy/falsiness.
python .\core.py validate -s sdtmig -v 3-4 --local_rules C:\TEMP\core-windows\my_rules -d ..\m5\datasets\cdiscpilot01\tabulations\sdtm\ this was the command run by Anthony
resulting in this error: Traceback (most recent call last): File "C:\TEMP\cdisc-rules-engine-main\core.py", line 516, in
cli()
File "C:\TEMP\cdisc-rules-engine-main\venv\lib\site-packages\click\core.py", line 1130, in call
return self.main(args, kwargs)
File "C:\TEMP\cdisc-rules-engine-main\venv\lib\site-packages\click\core.py", line 1055, in main
rv = self.invoke(ctx)
File "C:\TEMP\cdisc-rules-engine-main\venv\lib\site-packages\click\core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "C:\TEMP\cdisc-rules-engine-main\venv\lib\site-packages\click\core.py", line 1404, in invoke
return ctx.invoke(self.callback, ctx.params)
File "C:\TEMP\cdisc-rules-engine-main\venv\lib\site-packages\click\core.py", line 760, in invoke
return __callback(args, *kwargs)
File "C:\TEMP\cdisc-rules-engine-main\venv\lib\site-packages\click\decorators.py", line 26, in new_func
return f(get_current_context(), args, **kwargs)
File "C:\TEMP\cdisc-rules-engine-main\core.py", line 240, in validate
run_validation(
File "C:\TEMP\cdisc-rules-engine-main\scripts\run_validation.py", line 119, in run_validation
rules = get_rules(args)
File "C:\TEMP\cdisc-rules-engine-main\scripts\script_utils.py", line 123, in get_rules
load_rules_from_local(args) if args.local_rules else load_rules_from_cache(args)
File "C:\TEMP\cdisc-rules-engine-main\scripts\script_utils.py", line 195, in load_rules_from_local
if missing_keys:
UnboundLocalError: local variable 'missing_keys' referenced before assignment
since no keys were specified in args.rules using the -r flag, the filter to initialize missing_keys is not entered. I have removed the if missing_keys filter--this logic should only be entered if rule IDs are specified with the -r flag and we want to determine if rules were specified that are not present in the local directory.