Xml supp domains - Githubissues

cdisc-org / cdisc-rules-engine

Open source offering of the cdisc rules engine

MIT License

45 stars 12 forks source link

Xml supp domains #722

Closed SFJohnson24 closed 3 days ago

SFJohnson24 commented 3 weeks ago

this PR

addresses naming issues with XML
refines is_split_dataset using its naming convention so that supp datasets do not trigger split_dataset control flow. Addressing split merge logic will be addressed in ISS-345
fixes merge logic using a merge_key that is added to the two dataframes and subsequently removed following merge.

RamilCDISC commented 1 week ago

I ran test in rule engine using the test data from the connected issue. I noticed that, If you see the attached screenshot of the generated report, the dataset name reported in the last column is XS for all, although it should be what is in the first column