search

cdisc-org / cdisc-rules-engine

Open source offering of the cdisc rules engine
MIT License
45 stars 12 forks source link

Rule blocked: CORERULES-CG0019 #735

Open SFJohnson24 opened 1 week ago

SFJohnson24 commented 1 week ago

see: https://github.com/cdisc-org/cdisc-rules-engine/pull/728#discussion_r1649790297 https://app.zenhub.com/workspaces/core-dx-63fe768d89cdf600116ba028/issues/gh/cdisc-org/cdisc-rules-engine/345

Rule Information Standard: SDTM Rule ID: CG0019 Rule Description: Each record is unique per sponsor defined key variables as documented in the define.xml

Describe the problem currently the merge logic to get CG0019 validating properly is behind a filter that is filtering only on the core_ID. This is not clean, reusable code.

Describe the solution the filter elif is_supp_dataset(self.datasets, self.domain) and self.rule.get("core_id") == "CDISC.SDTMIG.CG0019" needs to be reworked to be more inclusive for other rules which want this same merge to be done for their rule validation.

nickdedonder commented 1 day ago

@gerrycampion can you provide a solution to this problem?