Rule blocked: CORERULES-254/1186/3701

cdisc-org / cdisc-rules-engine

Open source offering of the cdisc rules engine

MIT License

46 stars 12 forks source link

Rule blocked: CORERULES-254/1186/3701 #748

Open SFJohnson24 opened 1 month ago

SFJohnson24 commented 1 month ago

see #557

https://jira.cdisc.org/browse/CORERULES-254 https://jira.cdisc.org/browse/CORERULES-1186 https://jira.cdisc.org/browse/CORERULES-3701

Describe the bug

Target_is_sorted_by needs to be validated to work with Dask, currently the operator is rooted in Pandas in its present implementation
this needs to be made more robust and able to handle partial dates, date and time comparisons for sorting

this should convert to the broadest contiguous date/time part for comparison

nickdedonder commented 1 month ago

If a time part is missing is should be substituted by "00:00:00" to be able to do the sorting, afterwards it gets cut off again. When comparing a date and a time, only those parts that are available will be compared. If a date a date is compared with a date/time, only the data part will be compared.