search

cdisc-org / conformance-rules-editor

MIT License
6 stars 3 forks source link

ISS-335: move rule schema from rules editor to core rules engine repo #184

Closed gerrycampion closed 1 year ago

gerrycampion commented 1 year ago

Depends on: https://github.com/cdisc-org/cdisc-rules-engine/pull/409

To test before the rule engine PR is merged, you can add this env var to local.settings.json:

To test after the merge:

Test steps:

  1. Confirm the env variables are configured correctly in the 3 static web app envs (dev, training, prod) via the azure portal
  2. Run the local rule editor using the appropriate env var from above
  3. Login to the local rule editor
  4. Navigate to http://localhost:4280/api/schema and confirm the json schema is returned
  5. Navigate back to http://localhost:4280
  6. Confirm the main page shows the rule template before selecting a rule
  7. Select a rule
  8. Ensure intellisense works in the editor pane
    • delete an operator name and allow the editor to suggest an operator with ctrl/cmd+space
  9. Ensure validation works in the editor pane
    • provide an invalid operator name and the editor should show yellow lines
    • hover over the yellow lines and the editor should provide a tooltip with valid operator names. At the end of the tooltip, it should provide the correct location of yaml-schema
  10. Ensure validation works in the testing pane
    • provide an invalid operator name
    • click on "Test" -> "Validate YAML against schema"
    • Confirm there is a red X and a list of validation errors in json
github-actions[bot] commented 1 year ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-flower-095494b10-184.centralus.azurestaticapps.net

github-actions[bot] commented 1 year ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-flower-095494b10-184.centralus.azurestaticapps.net

github-actions[bot] commented 1 year ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-flower-095494b10-184.centralus.azurestaticapps.net

RamilCDISC commented 1 year ago

The Acceptance criteria for this Issue is met, but while following the steps in the PR related to this issue, it is found that the intellisense doesn't work on pressing ctrl/command + space but only when space is pressed after entering a colon.