search

cdisc-org / conformance-rules-editor

MIT License
6 stars 3 forks source link

Rule Editor Goes Blank when a excel File other than Dataset is uploaded #185

Closed RamilCDISC closed 1 year ago

RamilCDISC commented 1 year ago

Problem

In the editor here: https://rule-editor.cdisc.org/, if a file other than dataset file is uploaded, the whole editor goes blank, as seen in the attached screenshot.

To Reproduce

  1. Go to the editor
  2. Select any rule and go to the TEST tab
  3. In the test Tab upload a define.xml file
  4. upload any excel file other than the proper datasets.

After this the editor goes Blank

Possible Reason

This can be due to some unhandled exception in the code which is raised when it tries to read content from the dataset.

Recommendation

The uploaded file should be checked, if it is valid normal working should continue, otherwise an error message should be displayed. Handling this exception will make rule-editor more stable.

rule editor exception handling
RamilCDISC commented 1 year ago

The editor now properly handles the case when a non dataset file is uploaded by returning error ion response. As now the editor do not crash, ticket is clear from QA.

185